tests/util: Add Content-Type: application/json request headers
#7895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `axum::Json` extractor requires this header to be present and rejects requests that don't have it. This change ensures we can move our code over from custom JSON parsing to the `axum` extractor eventually.
Turbo87
added
C-internal 🔧
|
the cargo team confirmed via Zulip that this header is being sent by cargo and has been for a long time :) |
LawnGnome
approved these changes
Jan 9, 2024
| @@ -139,8 +139,15 @@ pub trait RequestHelper { | |||
| /// Issue a PUT request | |||
| #[track_caller] | |||
| fn put<T>(&self, path: &str, body: impl Into<Bytes>) -> Response<T> { | |||
| let body = body.into(); | |||
| let is_json = body.starts_with(b"{") && body.ends_with(b"}"); | |||
There was a problem hiding this comment.
I feel like this will eventually cause someone to have an annoying day writing tests if we ever add an endpoint that doesn't expect an object, but presumably that's not an issue right now.
I guess the other option would be to add a parallel put_json method that sets the header. I don't feel very strongly about this. 🤷
There was a problem hiding this comment.
yeah, though arguably APIs shouldn't return raw arrays anyway and that extra friction might be good 😄
the only PUT that does not deal with Json currently is the publish endpoint. it felt not worth it to have a dedicated method just for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
axum::Jsonextractor requires this header to be present and rejects requests that don't have it. This change ensures we can move our code over from custom JSON parsing to theaxumextractor eventually.