Skip to content

krate/publish: Avoid panic for truncated payloads #6393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 26, 2023

cargo should not send such requests, but apparently some clever user with their Postman app has figured out that this is a great way to have the request handler panic... 😄

on the bright side, tokio/hyper/axum/something is catching it correctly and transforming it into an internal server error without actually crashing our server. 🎉

@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-backend ⚙️ labels Apr 26, 2023
`cargo` should not send such requests, but apparently some clever user with their Postman app has figured out that this is a great way to have the request handler panic... 😄

on the bright side, tokio/hyper/axum/something is catching it correctly and transforming it into an internal server error without actually crashing our server. 🎉
@Turbo87 Turbo87 enabled auto-merge (squash) April 26, 2023 15:17
@Turbo87 Turbo87 merged commit 4f6fad1 into rust-lang:master Apr 26, 2023
@Turbo87 Turbo87 deleted the dont-panic branch April 26, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant