PUT /me/token: Remove unused revoked field from response payload
#6316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
The `revoked` field is not used by the frontend, and the only API endpoint that returns the `revoked` field is the one that creates a brand new token, in which case it makes no sense for the token to be immediately revoked. This is technically a breaking change, but since this endpoint is only meant to be used by the frontend when creating new tokens via the user interface the risk of breaking something should be fairly small.
|
The cargo team confirmed on Zulip that they are okay with this change, so I'll go ahead and merge this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
revokedfield is not used by the frontend, and the only API endpoint that returns therevokedfield is the one that creates a brand new token, in which case it makes no sense for the token to be immediately revoked.This is technically a breaking change, but since this endpoint is only meant to be used by the frontend when creating new tokens via the user interface the risk of breaking something should be fairly small.