Share the existing background job connection with (only) some jobs #5918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-changes" This reverts commit 838ac1d, reversing changes made to a732c1f. This reintroduces changes that were originally landed in rust-lang#5837 and reverted in rust-lang#5909.
Some jobs are long running and should not run within an existing transaction.
Turbo87
added
C-internal 🔧
|
I'm not expecting any issues, but I have time to monitor things for a while so I'm going to merge and deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the deadlock issues seen in the initial implementation in #5837. The first commit reverts the revert done in #5909. The second commit then adds the connection pool back to the state available within
Job::perform(), though now the pool is anOption<_>and only available in production. If test coverage of these background jobs is ever desired it could potentially be implemented with the existing infrastructure used inunhealthy_databasetests.