Use axum::DefaultBodyLimit for request payload size limiting
#5904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
The `DefaultBodyLimit` is 2 MB by default but can be adjusted per route. This commit changes our code to use the default limit, except for the publish endpoint which uses a custom 128 MB limit, like before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DefaultBodyLimitis 2 MB by default but can be adjusted per route. This PR changes our code to use the default limit, except for the publish endpoint which uses a custom 128 MB limit, like before.The previous approach used a custom
check_content_length()function that we imported fromconduit, but sinceaxumhas this functionality essentially built-in we should migrate to that.