publish: Avoid redundant buffer copies #5903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were buffering the incoming
hyper::Body
into abytes::Bytes
instance, which we then wrapped in aCursor
, which we then used as aRead
implementation to fill aVec<u8>
. This was somewhat wasteful because it meant that we were buffering the tarball payload twice: once in theBytes
and once more in theVec<u8>
.This PR changes the implementation to take more advantage of the
Arc
-like behavior ofbytes::Bytes
. We implement asplit_body()
function, which turns oneBytes
instance into twoBytes
, one for the JSON metadata, and one for the tarball payload. This will just shuffle around a few pointers underneath, without performing any additional memory allocation.In this PR we also slightly refactor the S3 uploader implementation to not require a redundant seek operation, which makes the above implementation a bit easier.