Skip to content

util/errors: Simplify internal() fn #5878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2023
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 6, 2023

Previously it was impossible to call this function directly with a String. If instead internal(&the_string) was used then an unnecessary clone of the original string was performed.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Jan 6, 2023
@Turbo87 Turbo87 merged commit c0d3340 into rust-lang:master Jan 7, 2023
@Turbo87 Turbo87 deleted the internal branch January 7, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant