Skip to content

Convert all request handlers to async functions #5859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Jan 5, 2023
Merged

Convert all request handlers to async functions #5859

merged 51 commits into from
Jan 5, 2023

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 5, 2023

This replaces the conduit() usage in the router with async functions, using conduit_compat() inside to encapsulate the synchronously blocking code.

This will finally allow us to use other axum extractors in these functions too :)

Turbo87 added 30 commits January 5, 2023 19:43
@Turbo87
GET /crates: Convert to async fn
a9a3cd9
@Turbo87
PUT /crates/new: Convert to async fn
ee95c35
@Turbo87
GET /crates/:crate_id/owners: Convert to async fn
8f2579b
@Turbo87
PUT /crates/:crate_id/owners: Convert to async fn
d2b2ea3
@Turbo87
DELETE /crates/:crate_id/owners: Convert to async fn
816aa82
@Turbo87
DELETE /crates/:crate_id/:version/yank: Convert to async fn
81e3c5a
@Turbo87
PUT /crates/:crate_id/:version/unyank: Convert to async fn
77fe098
@Turbo87
GET /crates/:crate_id/:version/download: Convert to async fn
c3de39c
@Turbo87
GET /versions: Convert to async fn
0c7037e
@Turbo87
GET /versions/:version_id: Convert to async fn
7fd9b1a
@Turbo87
GET /crates/:crate_id: Convert to async fn
c444aef
@Turbo87
GET /crates/:crate_id/:version: Convert to async fn
7657cee
@Turbo87
GET /crates/:crate_id/:version/readme: Convert to async fn
eb44b40
@Turbo87
GET /crates/:crate_id/:version/dependencies: Convert to async fn
7c8806b
@Turbo87
GET /crates/:crate_id/:version/downloads: Convert to async fn
75301b3
@Turbo87
GET /crates/:crate_id/:version/authors: Convert to async fn
3200aab
@Turbo87
GET /crates/:crate_id/downloads: Convert to async fn
50269a8
@Turbo87
GET /crates/:crate_id/versions: Convert to async fn
d1df03a
@Turbo87
PUT /crates/:crate_id/follow: Convert to async fn
2c4b8c2
@Turbo87
DELETE /crates/:crate_id/follow: Convert to async fn
15d1eaa
@Turbo87
GET /crates/:crate_id/following: Convert to async fn
cd29dcd
@Turbo87
GET /crates/:crate_id/owner_team: Convert to async fn
6653488
@Turbo87
GET /crates/:crate_id/owner_user: Convert to async fn
ffb82da
@Turbo87
GET /crates/:crate_id/reverse_dependencies: Convert to async fn
b4822fd
@Turbo87
GET /categories: Convert to async fn
25038e9
@Turbo87
GET /categories/:category_id: Convert to async fn
dffac05
@Turbo87
GET /category_slugs: Convert to async fn
6ad8f3a
@Turbo87
GET /users/:user_id: Convert to async fn
24c10c2
@Turbo87
PUT /users/:user_id: Convert to async fn
67a5b97
@Turbo87
GET /users/:user_id/stats: Convert to async fn
c008bd6
Turbo87 added 21 commits January 5, 2023 21:03
@Turbo87
GET /teams/:team_id: Convert to async fn
e17e26c
@Turbo87
GET /session/authorize: Convert to async fn
5206516
@Turbo87
GET /me: Convert to async fn
f2a7746
@Turbo87
GET /me/updates: Convert to async fn
15702ad
@Turbo87
GET /me/tokens: Convert to async fn
e02c292
@Turbo87
PUT /me/tokens: Convert to async fn
4317888
@Turbo87
DELETE /me/tokens/:id: Convert to async fn
3915296
@Turbo87
DELETE /tokens/current: Convert to async fn
c22703f
@Turbo87
GET /me/crate_owner_invitations: Convert to async fn
c912975
@Turbo87
PUT /me/crate_owner_invitations/:crate_id: Convert to async fn
956bfae
@Turbo87
PUT /me/crate_owner_invitations/accept/:token: Convert to async fn
62816d6
@Turbo87
PUT /me/email_notifications: Convert to async fn
1eaecde
@Turbo87
GET /summary: Convert to async fn
e4f710d
@Turbo87
PUT /confirm/:email_token: Convert to async fn
1e420a1
@Turbo87
PUT /users/:user_id/resend: Convert to async fn
c3ec214
@Turbo87
GET /session/begin: Convert to async fn
1e7458a
@Turbo87
DELETE /session: Convert to async fn
ef54a3a
@Turbo87
GET /metrics/:kind: Convert to async fn
40bfc45
@Turbo87
GET /crate_owner_invitations: Convert to async fn
02b699c
@Turbo87
POST /github/secret-scanning/verify: Convert to async fn
917c90f
@Turbo87
router: Remove obsolete conduit() fn
d59cc90
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Jan 5, 2023
@Turbo87 Turbo87 merged commit f38ea80 into rust-lang:master Jan 5, 2023
@Turbo87 Turbo87 deleted the async-fns branch January 5, 2023 20:25
@bors bors mentioned this pull request Jan 5, 2023
Merged
@Turbo87 Turbo87 mentioned this pull request Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Turbo87