Skip to content

eslint: Add qunit plugin #5524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 22, 2022
Merged

eslint: Add qunit plugin #5524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
091daee
tests: Use `assert.true/false()` where possible
Turbo87 Nov 22, 2022
0a16b74
tests: Use `assert.notOk()` instead of negated `assert.ok()`
Turbo87 Nov 22, 2022
1876d7a
Replace `assert.equals()` with `assert.strictEquals()`
Turbo87 Nov 22, 2022
66e2dc1
tests/reverse-dependencies: Fix duplicated test name
Turbo87 Nov 22, 2022
40f175d
eslint: Add `qunit` plugin
Turbo87 Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ module.exports = {
extends: [
'eslint:recommended',
'plugin:ember/recommended',
'plugin:qunit/recommended',
'plugin:qunit-dom/recommended',
'plugin:unicorn/recommended',
'plugin:prettier/recommended',
Expand All @@ -37,6 +38,9 @@ module.exports = {
'ember-concurrency/no-perform-without-catch': 'warn',
'ember-concurrency/require-task-name-suffix': 'error',

// disabled because of false positives in `assert.rejects()` calls
'qunit/require-expect': 'off',

'unicorn/explicit-length-check': ['error', { 'non-zero': 'not-equal' }],
// disabled because of false positives related to `EmberArray`
'unicorn/no-array-for-each': 'off',
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@
"eslint-plugin-ember-concurrency": "0.5.1",
"eslint-plugin-import-helpers": "1.3.1",
"eslint-plugin-prettier": "4.2.1",
"eslint-plugin-qunit": "7.3.3",
"eslint-plugin-qunit-dom": "0.2.0",
"eslint-plugin-unicorn": "45.0.0",
"loader.js": "4.7.0",
Expand Down
12 changes: 12 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/acceptance/404-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module('Acceptance | 404', function (hooks) {

test('/unknown-route shows a 404 page', async function (assert) {
await visit('/unknown-route');
assert.equal(currentURL(), '/unknown-route');
assert.strictEqual(currentURL(), '/unknown-route');
assert.dom('[data-test-404-page]').exists();
assert.dom('[data-test-title]').hasText('Page not found');
assert.dom('[data-test-go-back]').exists();
Expand Down
14 changes: 9 additions & 5 deletions tests/acceptance/api-token-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module('Acceptance | api-tokens', function (hooks) {
prepare(this);

await visit('/settings/tokens');
assert.equal(currentURL(), '/settings/tokens');
assert.strictEqual(currentURL(), '/settings/tokens');
assert.dom('[data-test-api-token]').exists({ count: 2 });

let [row1, row2] = findAll('[data-test-api-token]');
Expand All @@ -67,11 +67,15 @@ module('Acceptance | api-tokens', function (hooks) {
prepare(this);

await visit('/settings/tokens');
assert.equal(currentURL(), '/settings/tokens');
assert.strictEqual(currentURL(), '/settings/tokens');
assert.dom('[data-test-api-token]').exists({ count: 2 });

await click('[data-test-api-token="1"] [data-test-revoke-token-button]');
assert.equal(this.server.schema.apiTokens.all().length, 1, 'API token has been deleted from the backend database');
assert.strictEqual(
this.server.schema.apiTokens.all().length,
1,
'API token has been deleted from the backend database',
);

assert.dom('[data-test-api-token]').exists({ count: 1 });
assert.dom('[data-test-api-token="2"]').exists();
Expand All @@ -86,7 +90,7 @@ module('Acceptance | api-tokens', function (hooks) {
});

await visit('/settings/tokens');
assert.equal(currentURL(), '/settings/tokens');
assert.strictEqual(currentURL(), '/settings/tokens');
assert.dom('[data-test-api-token]').exists({ count: 2 });

await click('[data-test-api-token="1"] [data-test-revoke-token-button]');
Expand All @@ -100,7 +104,7 @@ module('Acceptance | api-tokens', function (hooks) {
prepare(this);

await visit('/settings/tokens');
assert.equal(currentURL(), '/settings/tokens');
assert.strictEqual(currentURL(), '/settings/tokens');
assert.dom('[data-test-api-token]').exists({ count: 2 });
assert.dom('[data-test-focused-input]').doesNotExist();
assert.dom('[data-test-save-token-button]').doesNotExist();
Expand Down
16 changes: 8 additions & 8 deletions tests/acceptance/crate-dependencies-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ module('Acceptance | crate dependencies page', function (hooks) {
this.server.loadFixtures();

await visit('/crates/nanomsg/dependencies');
assert.equal(currentURL(), '/crates/nanomsg/0.6.1/dependencies');
assert.equal(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry');
assert.strictEqual(currentURL(), '/crates/nanomsg/0.6.1/dependencies');
assert.strictEqual(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry');

assert.dom('[data-test-dependencies] li').exists({ count: 2 });
assert.dom('[data-test-build-dependencies] li').exists({ count: 1 });
Expand All @@ -42,7 +42,7 @@ module('Acceptance | crate dependencies page', function (hooks) {

test('shows an error page if crate not found', async function (assert) {
await visit('/crates/foo/1.0.0/dependencies');
assert.equal(currentURL(), '/crates/foo/1.0.0/dependencies');
assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies');
assert.dom('[data-test-404-page]').exists();
assert.dom('[data-test-title]').hasText('foo: Crate not found');
assert.dom('[data-test-go-back]').exists();
Expand All @@ -53,7 +53,7 @@ module('Acceptance | crate dependencies page', function (hooks) {
this.server.get('/api/v1/crates/:crate_name', {}, 500);

await visit('/crates/foo/1.0.0/dependencies');
assert.equal(currentURL(), '/crates/foo/1.0.0/dependencies');
assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies');
assert.dom('[data-test-404-page]').exists();
assert.dom('[data-test-title]').hasText('foo: Failed to load crate data');
assert.dom('[data-test-go-back]').doesNotExist();
Expand All @@ -65,7 +65,7 @@ module('Acceptance | crate dependencies page', function (hooks) {
this.server.create('version', { crate, num: '2.0.0' });

await visit('/crates/foo/1.0.0/dependencies');
assert.equal(currentURL(), '/crates/foo/1.0.0/dependencies');
assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies');
assert.dom('[data-test-404-page]').exists();
assert.dom('[data-test-title]').hasText('foo: Version 1.0.0 not found');
assert.dom('[data-test-go-back]').exists();
Expand All @@ -85,7 +85,7 @@ module('Acceptance | crate dependencies page', function (hooks) {
versions.forEach(record => record.unloadRecord());

await visit('/crates/foo/1.0.0/dependencies');
assert.equal(currentURL(), '/crates/foo/1.0.0/dependencies');
assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies');
assert.dom('[data-test-404-page]').exists();
assert.dom('[data-test-title]').hasText('foo: Failed to load version data');
assert.dom('[data-test-go-back]').doesNotExist();
Expand All @@ -99,7 +99,7 @@ module('Acceptance | crate dependencies page', function (hooks) {
this.server.get('/api/v1/crates/:crate_name/:version_num/dependencies', {}, 500);

await visit('/crates/foo/1.0.0/dependencies');
assert.equal(currentURL(), '/crates/foo/1.0.0/dependencies');
assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies');
assert.dom('[data-test-404-page]').exists();
assert.dom('[data-test-title]').hasText('foo: Failed to load dependencies');
assert.dom('[data-test-go-back]').doesNotExist();
Expand All @@ -121,7 +121,7 @@ module('Acceptance | crate dependencies page', function (hooks) {
this.server.get('/api/v1/crates', {}, 500);

await visit('/crates/nanomsg/dependencies');
assert.equal(currentURL(), '/crates/nanomsg/0.6.1/dependencies');
assert.strictEqual(currentURL(), '/crates/nanomsg/0.6.1/dependencies');

assert.dom('[data-test-dependencies] li').exists({ count: 2 });

Expand Down
8 changes: 4 additions & 4 deletions tests/acceptance/crate-navtabs-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ module('Acceptance | crate navigation tabs', function (hooks) {
this.server.create('version', { crate, num: '0.6.1' });

await visit('/crates/nanomsg');
assert.equal(currentURL(), '/crates/nanomsg');
assert.strictEqual(currentURL(), '/crates/nanomsg');

assert.dom(TAB_README).hasAttribute('href', '/crates/nanomsg').hasAttribute('data-test-active');
assert.dom(TAB_VERSIONS).hasAttribute('href', '/crates/nanomsg/versions').hasNoAttribute('data-test-active');
Expand All @@ -29,7 +29,7 @@ module('Acceptance | crate navigation tabs', function (hooks) {
assert.dom(TAB_SETTINGS).doesNotExist();

await click(TAB_VERSIONS);
assert.equal(currentURL(), '/crates/nanomsg/versions');
assert.strictEqual(currentURL(), '/crates/nanomsg/versions');

assert.dom(TAB_README).hasAttribute('href', '/crates/nanomsg').hasNoAttribute('data-test-active');
assert.dom(TAB_VERSIONS).hasAttribute('href', '/crates/nanomsg/versions').hasAttribute('data-test-active');
Expand All @@ -41,7 +41,7 @@ module('Acceptance | crate navigation tabs', function (hooks) {
assert.dom(TAB_SETTINGS).doesNotExist();

await click(TAB_DEPS);
assert.equal(currentURL(), '/crates/nanomsg/0.6.1/dependencies');
assert.strictEqual(currentURL(), '/crates/nanomsg/0.6.1/dependencies');

assert.dom(TAB_README).hasAttribute('href', '/crates/nanomsg/0.6.1').hasNoAttribute('data-test-active');
assert.dom(TAB_VERSIONS).hasAttribute('href', '/crates/nanomsg/versions').hasNoAttribute('data-test-active');
Expand All @@ -53,7 +53,7 @@ module('Acceptance | crate navigation tabs', function (hooks) {
assert.dom(TAB_SETTINGS).doesNotExist();

await click(TAB_REV_DEPS);
assert.equal(currentURL(), '/crates/nanomsg/reverse_dependencies');
assert.strictEqual(currentURL(), '/crates/nanomsg/reverse_dependencies');

assert.dom(TAB_README).hasAttribute('href', '/crates/nanomsg').hasNoAttribute('data-test-active');
assert.dom(TAB_VERSIONS).hasAttribute('href', '/crates/nanomsg/versions').hasNoAttribute('data-test-active');
Expand Down
38 changes: 19 additions & 19 deletions tests/acceptance/crate-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ module('Acceptance | crate page', function (hooks) {
await visit('/');
await click('[data-test-just-updated] [data-test-crate-link="0"]');

assert.equal(currentURL(), '/crates/nanomsg');
assert.equal(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry');
assert.strictEqual(currentURL(), '/crates/nanomsg');
assert.strictEqual(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry');

assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg');
assert.dom('[data-test-heading] [data-test-crate-version]').hasText('v0.6.1');
Expand All @@ -34,9 +34,9 @@ module('Acceptance | crate page', function (hooks) {

await visit('/crates/nanomsg');

assert.equal(currentURL(), '/crates/nanomsg');
assert.equal(currentRouteName(), 'crate.index');
assert.equal(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry');
assert.strictEqual(currentURL(), '/crates/nanomsg');
assert.strictEqual(currentRouteName(), 'crate.index');
assert.strictEqual(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry');

assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg');
assert.dom('[data-test-heading] [data-test-crate-version]').hasText('v0.6.1');
Expand All @@ -53,9 +53,9 @@ module('Acceptance | crate page', function (hooks) {

await visit('/crates/nanomsg/');

assert.equal(currentURL(), '/crates/nanomsg/');
assert.equal(currentRouteName(), 'crate.index');
assert.equal(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry');
assert.strictEqual(currentURL(), '/crates/nanomsg/');
assert.strictEqual(currentRouteName(), 'crate.index');
assert.strictEqual(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry');

assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg');
assert.dom('[data-test-heading] [data-test-crate-version]').hasText('v0.6.1');
Expand All @@ -69,9 +69,9 @@ module('Acceptance | crate page', function (hooks) {

await visit('/crates/nanomsg/0.6.0');

assert.equal(currentURL(), '/crates/nanomsg/0.6.0');
assert.equal(currentRouteName(), 'crate.version');
assert.equal(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry');
assert.strictEqual(currentURL(), '/crates/nanomsg/0.6.0');
assert.strictEqual(currentRouteName(), 'crate.version');
assert.strictEqual(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry');

assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg');
assert.dom('[data-test-heading] [data-test-crate-version]').hasText('v0.6.0');
Expand All @@ -83,7 +83,7 @@ module('Acceptance | crate page', function (hooks) {

test('unknown crate shows an error message', async function (assert) {
await visit('/crates/nanomsg');
assert.equal(currentURL(), '/crates/nanomsg');
assert.strictEqual(currentURL(), '/crates/nanomsg');
assert.dom('[data-test-404-page]').exists();
assert.dom('[data-test-title]').hasText('nanomsg: Crate not found');
assert.dom('[data-test-go-back]').exists();
Expand All @@ -94,7 +94,7 @@ module('Acceptance | crate page', function (hooks) {
this.server.get('/api/v1/crates/:crate_name', {}, 500);

await visit('/crates/nanomsg');
assert.equal(currentURL(), '/crates/nanomsg');
assert.strictEqual(currentURL(), '/crates/nanomsg');
assert.dom('[data-test-404-page]').exists();
assert.dom('[data-test-title]').hasText('nanomsg: Failed to load crate data');
assert.dom('[data-test-go-back]').doesNotExist();
Expand All @@ -108,7 +108,7 @@ module('Acceptance | crate page', function (hooks) {

await visit('/crates/nanomsg/0.7.0');

assert.equal(currentURL(), '/crates/nanomsg/0.7.0');
assert.strictEqual(currentURL(), '/crates/nanomsg/0.7.0');
assert.dom('[data-test-404-page]').exists();
assert.dom('[data-test-title]').hasText('nanomsg: Version 0.7.0 not found');
assert.dom('[data-test-go-back]').exists();
Expand All @@ -124,7 +124,7 @@ module('Acceptance | crate page', function (hooks) {

await visit('/');
await click('[data-test-just-updated] [data-test-crate-link="0"]');
assert.equal(currentURL(), '/crates/nanomsg');
assert.strictEqual(currentURL(), '/crates/nanomsg');
assert.dom('[data-test-404-page]').exists();
assert.dom('[data-test-title]').hasText('nanomsg: Failed to load version data');
assert.dom('[data-test-go-back]').doesNotExist();
Expand All @@ -146,7 +146,7 @@ module('Acceptance | crate page', function (hooks) {
await visit('/crates/nanomsg');
await click('[data-test-rev-deps-tab] a');

assert.equal(currentURL(), '/crates/nanomsg/reverse_dependencies');
assert.strictEqual(currentURL(), '/crates/nanomsg/reverse_dependencies');
assert.dom('a[href="/crates/unicorn-rpc"]').hasText('unicorn-rpc');
});

Expand All @@ -156,7 +156,7 @@ module('Acceptance | crate page', function (hooks) {
await visit('/crates/nanomsg');
await click('[data-test-owners] [data-test-owner-link="blabaere"]');

assert.equal(currentURL(), '/users/blabaere');
assert.strictEqual(currentURL(), '/users/blabaere');
assert.dom('[data-test-heading] [data-test-username]').hasText('blabaere');
});

Expand All @@ -166,7 +166,7 @@ module('Acceptance | crate page', function (hooks) {
await visit('/crates/nanomsg');
await click('[data-test-owners] [data-test-owner-link="github:org:thehydroimpulse"]');

assert.equal(currentURL(), '/teams/github:org:thehydroimpulse');
assert.strictEqual(currentURL(), '/teams/github:org:thehydroimpulse');
assert.dom('[data-test-heading] [data-test-team-name]').hasText('thehydroimpulseteam');
});

Expand Down Expand Up @@ -248,6 +248,6 @@ module('Acceptance | crate page', function (hooks) {
await visit('/crates/nanomsg');
await click('[data-test-settings-tab] a');

assert.equal(currentURL(), '/crates/nanomsg/settings');
assert.strictEqual(currentURL(), '/crates/nanomsg/settings');
});
});
10 changes: 5 additions & 5 deletions tests/acceptance/crates-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ module('Acceptance | crates page', function (hooks) {
await visit('/');
await click('[data-test-all-crates-link]');

assert.equal(currentURL(), '/crates');
assert.equal(getPageTitle(), 'Crates - crates.io: Rust Package Registry');
assert.strictEqual(currentURL(), '/crates');
assert.strictEqual(getPageTitle(), 'Crates - crates.io: Rust Package Registry');

await percySnapshot(assert);
await a11yAudit(axeConfig);
Expand All @@ -34,8 +34,8 @@ module('Acceptance | crates page', function (hooks) {
await visit('/crates');
await click('[data-test-all-crates-link]');

assert.equal(currentURL(), '/crates');
assert.equal(getPageTitle(), 'Crates - crates.io: Rust Package Registry');
assert.strictEqual(currentURL(), '/crates');
assert.strictEqual(getPageTitle(), 'Crates - crates.io: Rust Package Registry');
});

test('listing crates', async function (assert) {
Expand All @@ -61,7 +61,7 @@ module('Acceptance | crates page', function (hooks) {
await visit('/crates');
await click('[data-test-pagination-next]');

assert.equal(currentURL(), '/crates?page=2');
assert.strictEqual(currentURL(), '/crates?page=2');
assert.dom('[data-test-crates-nav] [data-test-current-rows]').hasText(`${page_start}-${total}`);
assert.dom('[data-test-crates-nav] [data-test-total-rows]').hasText(`${total}`);
});
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/dashboard-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module('Acceptance | Dashboard', function (hooks) {

test('shows "page requires authentication" error when not logged in', async function (assert) {
await visit('/dashboard');
assert.equal(currentURL(), '/dashboard');
assert.strictEqual(currentURL(), '/dashboard');
assert.dom('[data-test-title]').hasText('This page requires authentication');
assert.dom('[data-test-login]').exists();
});
Expand Down Expand Up @@ -55,7 +55,7 @@ module('Acceptance | Dashboard', function (hooks) {
this.server.get(`/api/v1/users/${user.id}/stats`, { total_downloads: 3892 });

await visit('/dashboard');
assert.equal(currentURL(), '/dashboard');
assert.strictEqual(currentURL(), '/dashboard');
await percySnapshot(assert);
});
});
Loading