Use a fluid space scale #5370
Merged
Use a fluid space scale #5370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
Turbo87
force-pushed
the
fluid-space-scale
branch
from
aef87d8 to
e8d6b91
Compare
Turbo87
force-pushed
the
fluid-space-scale
branch
from
e8d6b91 to
a68ecbf
Compare
|
let's do this...! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buckle up, this is a big one...! 😅
This PR introduces several new CSS variables prefixed with
--space, which should be used instead of hardcoding arbitrary pixel values. These values are also "fluid" in that they change their values depending on the viewport width. The concepts behind this are explained at https://utopia.fyi/.We are using this scale: https://utopia.fyi/space/calculator?c=320,14,1.2,1140,18,1.25,5,2,&s=0.75|0.5|0.25|0.125,1.5|2|3|4|6,s-l
The pages look quite similar before and after this change, but some of them scale a little better down to mobile viewports.