Skip to content

admin/upload-index: Restore "skipping file" output #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Aug 8, 2022

#4836 migrated the admin tool to use indicatif for progress reporting, but back then there was no way to output additional messages without disturbing the progress bar. With the latest release of indicatif a suspend() method was introduced which allows us to restore the original behavior.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Aug 8, 2022
@Turbo87 Turbo87 force-pushed the upload-index-printing branch from 6028a49 to 590e25f Compare August 8, 2022 20:36
@Turbo87 Turbo87 force-pushed the upload-index-printing branch from 590e25f to ec7685a Compare August 8, 2022 20:38
@Turbo87 Turbo87 merged commit 8e234a8 into rust-lang:master Aug 9, 2022
@Turbo87 Turbo87 deleted the upload-index-printing branch August 9, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant