Skip to content

Replace timekeeper with @sinonjs/fake-timers #4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 2, 2022

timekeeper is not really maintained anymore. @sinonjs/fake-timers is well maintained and has a few additional nice features.

@Turbo87 Turbo87 added A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Jan 2, 2022
@Turbo87 Turbo87 requested review from locks and pichfl January 2, 2022 18:59
@Turbo87 Turbo87 force-pushed the sinon-fake-timers branch from 4c60ab9 to ea66dfc Compare January 3, 2022 08:53
@Turbo87
Copy link
Member Author

Turbo87 commented Jan 3, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 3, 2022

📌 Commit ea66dfc has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Jan 3, 2022

⌛ Testing commit ea66dfc with merge b07754a...

@bors
Copy link
Contributor

bors commented Jan 3, 2022

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing b07754a to master...

@bors bors merged commit b07754a into rust-lang:master Jan 3, 2022
@Turbo87 Turbo87 deleted the sinon-fake-timers branch January 3, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants