-
Notifications
You must be signed in to change notification settings - Fork 649
worker::git: Read yanked
status from database
#4175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks fine 👍 @bors r+ |
📌 Commit 51f52cb has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
☔ The latest upstream changes (presumably #4173) made this pull request unmergeable. Please resolve the merge conflicts. |
We only need the `num` field, so there is no need for us to save the full `Version` in the task payload
This avoids out-of-order issues when previous tasks failed and are retried at the end of the queue.
@bors r=JohnTitor |
📌 Commit 552ae26 has been approved by |
☀️ Test successful - checks-actions |
This PR implements one part of #4172. By no longer passing
yanked
into theyank
(nowsync_yanked
) background worker task, and instead readingyanked
from the database, we can avoid issues from tasks running out of order.