admin::on_call: Work around potential Rust v1.57.0-beta.1 bug #4030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
A-backend ⚙️
C-internal 🔧
|
@bors r+ |
|
📌 Commit 2f3988e has been approved by |
|
☀️ Test successful - checks-actions |
|
for reference, this got reported at rust-lang/rust#90046 and it looks like there was also a previous issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields in the
InvalidEventstruct are used by theDebugimplementation, which is used by theanyhow!()macro call in theEvent::send()implementation.The Rust v1.57.0-beta.1 compiler does not appear to agree on that though and marks these fields as unused. This PR adds
#[allow(dead_code)]to work around the issue for now and fix our CI builds to unblock other updates.