Skip to content

Header: Implement @hero mode for the index route #4026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 26, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 18, 2021

Bildschirmfoto 2021-10-18 um 22 56 48

Bildschirmfoto 2021-10-18 um 22 57 10

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Oct 18, 2021
@Turbo87 Turbo87 requested review from locks and pichfl October 18, 2021 20:59
@Turbo87 Turbo87 changed the title Header: Implement @hero mode for the index route Header: Implement @hero mode for the index route Oct 18, 2021
@Turbo87 Turbo87 force-pushed the hero-header branch 2 times, most recently from f137f49 to 1e09acb Compare October 21, 2021 12:30
@locks
Copy link
Contributor

locks commented Oct 25, 2021

I really like this, very fresh and clean! Should I give bors the go ahead or do you want input from @pichfl ?

@locks
Copy link
Contributor

locks commented Oct 26, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 26, 2021

📌 Commit 06aee0c has been approved by locks

@bors
Copy link
Contributor

bors commented Oct 26, 2021

⌛ Testing commit 06aee0c with merge 70a46c2...

@bors
Copy link
Contributor

bors commented Oct 26, 2021

☀️ Test successful - checks-actions
Approved by: locks
Pushing 70a46c2 to master...

@bors bors merged commit 70a46c2 into rust-lang:master Oct 26, 2021
@Turbo87 Turbo87 deleted the hero-header branch October 26, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants