Add tests for admin/render_readmes #3969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipunn1313
force-pushed
the
rerender_readme2
branch
from
75ced35 to
2c1ba64
Compare
Turbo87
force-pushed
the
rerender_readme2
branch
from
2c1ba64 to
5ca4751
Compare
|
@nipunn1313 I took the liberty of rebasing your branch and splitting it up into a few more individual commits. I hope thats okay with you :) |
Turbo87
added
A-backend ⚙️
C-internal 🔧
|
@bors r+ |
|
📌 Commit 5ca4751 has been approved by |
|
☀️ Test successful - checks-actions |
|
Perfect. The split up commits make a lot of sense to me!
…On Fri, Oct 1, 2021 at 1:25 AM bors ***@***.***> wrote:
Merged #3969 <#3969> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3969 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ5PI43FIJ5B5E7OG45QRDUEVWAJANCNFSM5FDRSSGQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
bors
added a commit
that referenced
this pull request
Oct 5, 2021
Support admin render_readme with Cargo.toml without optional readme field Depends on #3969 (Because of community/community#4477 (comment) - github ends up rendering both diffs together. Go to the commits tab and just look at the most recent commit to review). https://doc.rust-lang.org/cargo/reference/manifest.html#the-readme-field
bors
added a commit
that referenced
this pull request
Oct 5, 2021
Support admin render_readme with Cargo.toml without optional readme field Depends on #3969 (Because of community/community#4477 (comment) - github ends up rendering both diffs together. Go to the commits tab and just look at the most recent commit to review). https://doc.rust-lang.org/cargo/reference/manifest.html#the-readme-field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3967
(Because of community/community#4477 (comment) - github ends up rendering both diffs together. Go to the commits tab and just look at the most recent commit to review).
Refactors slightly so we can add tests to the untested risky portion of this code.
I already found a couple of bugs which I will fix in follow up PRs with tests.