Skip to content

Use HeaderValue::from_static() instead of ::from(&str) #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2021
Merged

Use HeaderValue::from_static() instead of ::from(&str) #3956

merged 1 commit into from
Sep 25, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Sep 25, 2021

This should be slightly more efficient 😄

@Turbo87
Use HeaderValue::from_static() instead of ::from(&str)
3653d5c 
This should be slightly more efficient 😄
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Sep 25, 2021
@Turbo87 Turbo87 requested review from JohnTitor and 0xPoe September 25, 2021 07:29
0xPoe
0xPoe approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@0xPoe
Copy link
Member

0xPoe commented Sep 25, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Sep 25, 2021

📌 Commit 3653d5c has been approved by hi-rustin

@bors
Copy link
Contributor

bors commented Sep 25, 2021

⌛ Testing commit 3653d5c with merge 5ce3f14...

@bors
Copy link
Contributor

bors commented Sep 25, 2021

☀️ Test successful - checks-actions
Approved by: hi-rustin
Pushing 5ce3f14 to master...

@bors bors merged commit 5ce3f14 into rust-lang:master Sep 25, 2021
@Turbo87 Turbo87 deleted the headers branch September 26, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xPoe 0xPoe 0xPoe approved these changes

@JohnTitor JohnTitor Awaiting requested review from JohnTitor

Assignees
No one assigned
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Turbo87 @0xPoe @bors