Use minijinja instead of handlebars
#3951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
|
☔ The latest upstream changes (presumably #3959) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
minininja
branch
3 times, most recently
from
e341c60 to
668e793
Compare
JohnTitor
approved these changes
Oct 6, 2021
locks
approved these changes
Oct 10, 2021
`minijinja` is explicitly built to be a light-weight templating system with minimal dependencies. Since we don't use a lot of the complexity that a full templating system like `handlebars` brings, we can reduce our number of transitive dependencies by replacing `handlebars` with `minijinja`. Note that it currently does not reduce the number of dependencies significantly, because other dependencies are still depending on these other transitive dependencies... 🙈
|
@JohnTitor thanks! looks like Justin is currently quite busy with his new job. since we have tests for this functionality I feel quite confident that this should not break anything :) @bors r=JohnTitor |
|
📌 Commit bbdccd1 has been approved by |
|
☀️ Test successful - checks-actions |
|
just imported the database dump from tonight, and everything appears to be working well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minijinjais explicitly built to be a light-weight templating system with minimal dependencies. Since we don't use a lot of the complexity that a full templating system likehandlebarsbrings, we can reduce our number of transitive dependencies by replacinghandlebarswithminijinja. Note that it currently does not reduce the number of dependencies significantly, because other dependencies are still depending on these other transitive dependencies... 🙈see https://github.com/mitsuhiko/minijinja