Skip to content

Add a link to report a general issue #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2021
Merged

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Jul 19, 2021

close #3129

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@rust-highfive
Copy link

r? @smarnach

(rust-highfive has picked a reviewer for you, use r? to override)

@0xPoe
Copy link
Member Author

0xPoe commented Jul 19, 2021

image

I'm not sure we should force a line break?

@Turbo87 Turbo87 added A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works labels Jul 19, 2021
0xPoe added 2 commits July 25, 2021 09:21
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe 0xPoe requested a review from JohnTitor July 25, 2021 01:23
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good, though I'm going to defer the final review to another reviewer as I'm not sure if we need a style change.

@0xPoe
Copy link
Member Author

0xPoe commented Aug 1, 2021

PC:
image

mobile:
image

@0xPoe
Copy link
Member Author

0xPoe commented Aug 1, 2021

r? @jtgeibel

Could you please take a look? Thanks!

@rust-highfive rust-highfive assigned jtgeibel and unassigned smarnach Aug 1, 2021
@0xPoe
Copy link
Member Author

0xPoe commented Aug 16, 2021

@Turbo87

Could you please take a look? Thanks!

Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not the final state of the footer, but I guess this is a good intermediate step :)

@Turbo87
Copy link
Member

Turbo87 commented Aug 19, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Aug 19, 2021

📌 Commit ad0fba5 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Aug 19, 2021

⌛ Testing commit ad0fba5 with merge 0435e20...

@bors
Copy link
Contributor

bors commented Aug 19, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing 0435e20 to master...

@bors bors merged commit 0435e20 into rust-lang:master Aug 19, 2021
@epage
Copy link

epage commented Aug 19, 2021

As a user, "report an issue" sounds definitive, that I know there is an issue. I don't remember what issue led to #3129 but I had written "I was trying to get support with a potential problem with crates.io". The new link would not have helped me in this case. I probably would still click "send an email" because (1) it sounds closest to a means of support and (2) there is no clarification on when emailing should be used.

@0xPoe 0xPoe changed the title Add a link to report an Issue Add a link to report a general issue Aug 19, 2021
@0xPoe
Copy link
Member Author

0xPoe commented Aug 19, 2021

As a user, "report an issue" sounds definitive, that I know there is an issue. I don't remember what issue led to #3129 but I had written "I was trying to get support with a potential problem with crates.io". The new link would not have helped me in this case. I probably would still click "send an email" because (1) it sounds closest to a means of support and (2) there is no clarification on when emailing should be used.

The link I added here is report a general issue , maybe we do need a link that explains how to use them. This is not the final footer state, maybe we can consider it in a future design?

Also, I added it just thinking we could jump to here via a direct link. It's also what you mentioned in the possible alternative solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please highlight the performed form of support on crates.io
8 participants