Skip to content

Add labels to forms missing them #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Add labels to forms missing them #3431

merged 1 commit into from
Mar 19, 2021

Conversation

lf-
Copy link
Contributor

@lf- lf- commented Mar 19, 2021

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @smarnach (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Turbo87 Turbo87 added A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior labels Mar 19, 2021
@lf-
Copy link
Contributor Author

lf- commented Mar 19, 2021

I am utterly bewildered as to this CI failure. It seems to be failing because there are no errors? Can someone more familiar with the infrastructure help me with this?

(side note: I saw the warning about multiple landmark elements but was not sure how to fix it, and it was there before, so I'm leaving it to future work)

  -:-  error  Pending module (`app/components/settings/api-tokens`) passes all rules. Please remove `app/components/settings/api-tokens` from pending list.  invalid-pending-module

@Turbo87
Copy link
Member

Turbo87 commented Mar 19, 2021

@lf- I think you need to remove the files from https://github.com/rust-lang/crates.io/blob/master/.template-lintrc.js#L6

@lf-
Copy link
Contributor Author

lf- commented Mar 19, 2021

@lf- I think you need to remove the files from https://github.com/rust-lang/crates.io/blob/master/.template-lintrc.js#L6

Ahhh yup, that does it. Thanks!

@Turbo87
Copy link
Member

Turbo87 commented Mar 19, 2021

LGTM! thanks :)

I took the liberty to squash the commits together and rebase them.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 19, 2021

📌 Commit 31c2f67 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Mar 19, 2021

⌛ Testing commit 31c2f67 with merge b1beb4f...

@bors
Copy link
Contributor

bors commented Mar 19, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing b1beb4f to master...

@bors bors merged commit b1beb4f into rust-lang:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants