Skip to content

gitignore: Add .idea directory #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Mar 19, 2021

No description provided.

@rust-highfive
Copy link

r? @smarnach

(rust-highfive has picked a reviewer for you, use r? to override)

@Turbo87
Copy link
Member

Turbo87 commented Mar 19, 2021

@hi-rustin 👋

these kinds of files should usually be put in your global .gitignore file, to avoid having to add these kinds of files for all the different editors that exist.

@Turbo87 Turbo87 changed the title chore: ignore .idea dir gitignore: Add .idea directory Mar 19, 2021
@Turbo87 Turbo87 added the C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear label Mar 19, 2021
@0xPoe
Copy link
Member Author

0xPoe commented Mar 19, 2021

@hi-rustin 👋

these kinds of files should usually be put in your global .gitignore file, to avoid having to add these kinds of files for all the different editors that exist.

It seems we already have .vscode.

@Turbo87
Copy link
Member

Turbo87 commented Mar 19, 2021

It seems we already have .vscode.

true, though IMHO we shouldn't have added that one either.

btw there is more information on that at https://github.com/github/gitignore#a-collection-of-gitignore-templates :)

@0xPoe
Copy link
Member Author

0xPoe commented Mar 19, 2021

It seems we already have .vscode.

true, though IMHO we shouldn't have added that one either.

btw there is more information on that at https://github.com/github/gitignore#a-collection-of-gitignore-templates :)

Got it. Do we need to remove it? If not please feel free to close the pr.

@Turbo87
Copy link
Member

Turbo87 commented Mar 19, 2021

Do we need to remove it?

I didn't want to step on anyone's toes, which is why I hadn't removed it, but IMHO we probably should. I'll put this PR on the agenda for our team meeting on Discord later today so we can quickly discuss this.

@Turbo87
Copy link
Member

Turbo87 commented Mar 19, 2021

@hi-rustin we just discussed this, and removing the .vscode stuff is fine with everyone. I'll close this PR here to avoid confusion, but feel free to open a new one where .vscode is removed :)

@Turbo87 Turbo87 closed this Mar 19, 2021
bors added a commit that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants