Move router error handling into new middleware layer #3373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The outer R404 will catch any routing errors, so it is unnecessary here.
Other error conversions in `AppError::try_convert()` cannot be moved because endpoint logic relys on being able to detect these (converted) errors. Errors that endpoints don't care about (or cannot detect), can be converted to user-friendly errors in middleware.
Turbo87
approved these changes
Mar 8, 2021
src/router.rs
Outdated
| body, | ||
| Body::Owned(vec) if vec == br#"{"errors":[{"detail":"Not Found"}]}"# | ||
| )); | ||
| } |
There was a problem hiding this comment.
would it make sense to convert that to a more high-level API test?
There was a problem hiding this comment.
This particular test moved to the middleware. We could do something under tests/all.rs as well. The main difference would be that it would load other middleware layers as well.
|
@bors r=Turbo87 |
|
📌 Commit ff1f7cc has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves handling of routing errors into middleware and adds a test for the conversion.
Additionally we previously called
router.recognize()instead ofrouter.call(). By switching we can let theconduit-routerlogic handle addingParamsto the request extensions.A potential allocation is removed from json error handling, although the compiler may be able to eliminate that allocation already.
r? @Turbo87