Docker: Improve postgres setup
#3221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
docker-test-db
branch
2 times, most recently
from
e14d8d4 to
14368a8
Compare
|
Why was I mentioned here? Not that I have a problem with that, I'm just not sure if I wasn't supposed to do something 😅 |
|
@plaets only for awareness because you were working on the other Docker topics :) |
Turbo87
added
the
C-internal 🔧
Turbo87
force-pushed
the
docker-test-db
branch
from
14368a8 to
5a31acf
Compare
Turbo87
force-pushed
the
docker-test-db
branch
2 times, most recently
from
dca0c59 to
99a80e3
Compare
Turbo87
force-pushed
the
docker-test-db
branch
3 times, most recently
from
409bfb3 to
30a73ce
Compare
Turbo87
force-pushed
the
docker-test-db
branch
4 times, most recently
from
636a797 to
d6743a2
Compare
Docker by default exposes ports on 0.0.0.0
|
@bors r+ |
|
📌 Commit 1daff49 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to use the docker-compose setup to run
cargo testwith the Dockerized Postgres server. It also adjusts the docker-compose setup a little bit to not expose thepostgrescontainer on all host interfaces, but instead only makes it available on 127.0.0.1.To run just the database container you can use:
(
-druns it in daemon mode)/cc @plaets
r? @pietroalbini