Extract GitHubClient struct
#3218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HubUser` struct This is glue code that couples the `NewUser` model and the `GithubUser` response struct together. Having this tight coupling in the `impl` block makes it hard to pull the GitHub client into a dedicated module.
|
Reviewed commit by commit and everything checks out! @bors r+ |
|
📌 Commit 73b5b0c has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify our GitHub API request code a little bit by extracting a
GitHubClientstruct, and adding several request methods on it. It also allows to set a custombase_url, which will be useful in the future when used in combination with https://docs.rs/mockito.r? @pietroalbini