Load Intl polyfills, if needed
#3145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
r? @pichfl |
Turbo87
force-pushed
the
intl-polyfills
branch
from
59fe89a to
cfeff4d
Compare
|
@bors r+ |
|
📌 Commit cfeff4d has been approved by |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Jan 4, 2021
Replace `Intl.NumberFormat` usage This PR should hopefully fix #3158. I've not been able to reproduce the issue locally, but it looks like it's related to `Intl.NumberFormat` and the polyfill that #3145 introduced. Since we only need this code for number formatting, and we usually want to format in the user's browser locale we can instead use `.toLocaleString()`. I've extracted an `intl` service for this, which makes it easier to test the `format-num` helper, and brings the implementation closer to the ember-intl addon. r? `@pichfl`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out a few Chinese browsers don't ship with an
IntlAPI, and that causes several issues on Sentry.This PR adds optional polyfills for the
IntlAPIs that are loaded if necessary before the app boots.