models: Add missing pub declarations

[Turbo87]

Without these declarations it is quite hard to use these model structs outside of their files, and since the structs themselves are pub it makes sense for their fields to also be public.

r? @pietroalbini

[pietroalbini]

The intent of the fields not being pub is to force new initializations to go through the new method, which also does some validation. Why do you need the fields to be public?

[Turbo87]

I primarily need it on the ReverseDependency to replace the encodable() method with a From implementation. Without the fields being pub it is not possible to access the fields from the views module.

I added the other structs because I thought it would make sense for all of the structs in the models module to have pub fields, but maybe you're right. Do you want me to remove the other structs and only keep the rev dep commit?

[pietroalbini]

Ok, so, we definitely don't want fields to be pub for NewVersion (or any New*). For the others, I'd say let's add pub only when it's needed.

[Turbo87]

okay, I've removed the other three commits for now :)

[pietroalbini]

@bors r+

[bors]

📌 Commit 5a937a3 has been approved by pietroalbini

[bors]

⌛ Testing commit 5a937a3 with merge cce3de8...

[bors]

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing cce3de8 to master...