Properly sideload keywords in crates#show #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data is sent properly in this endpoint, but they aren't actually associated with the crate as the ids aren't present. This appears to be the only endpoint where these are sideloaded. I've added a test for this, but haven't visually verified the fix (as I don't have everything set up to run the backend locally), so this should be tested on staging before deployment. Fixes rust-lang#271
|
Thanks! |
alexcrichton
added a commit
that referenced
this pull request
Feb 25, 2016
Properly sideload keywords in crates#show
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data is sent properly in this endpoint, but they aren't actually
associated with the crate as the ids aren't present. This appears to be
the only endpoint where these are sideloaded.
I've added a test for this, but haven't visually verified the fix (as I
don't have everything set up to run the backend locally), so this should
be tested on staging before deployment.
Fixes #271