Remove mostly unused keywords column from crates table #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This column was present both in the table and in the Rust model, but was only ever used to update the search index on update. The actual source of keyword info is the crates_keywords table, and it's actually reasonably easy for this column to get out of sync. Instead of relying on things calling the `update_crate` function every time the keywords column is modified, we can instead populate the column with a subselect which grabs the keywords associated. This also means we need an additional trigger to touch the crate whenever the crates_keywords table is modified.
|
Oh man, I have so much sql-fu I need to learn. Thanks! |
alexcrichton
added a commit
that referenced
this pull request
Feb 20, 2016
Remove mostly unused keywords column from crates table
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This column was present both in the table and in the Rust model, but
was only ever used to update the search index on update. The actual
source of keyword info is the crates_keywords table, and it's actually
reasonably easy for this column to get out of sync.
Instead of relying on things calling the
update_cratefunction everytime the keywords column is modified, we can instead populate the column
with a subselect which grabs the keywords associated. This also means we
need an additional trigger to touch the crate whenever the
crates_keywords table is modified.