Upgrade ember #268
Merged
Upgrade ember #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 |
|
You should use ember@2.3.1 as it contains some important bugfixes. |
|
Thanks @mmun , added. |
steveklabnik
force-pushed
the
upgrade_ember
branch
from
fdba3d7 to
9e2f786
Compare
|
@steveklabnik make sure to test the login process and the downloads graph extra carefully, aside from that there shouldn't be any major problems ahead. :) |
|
It all checks out with me, thanks @steveklabnik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I skipped 2.2.0 because everything was going so smoothly.
All tests pass, I clicked around locally and it seemed to be working fine.