Add DELETE /tokens/current endpoint
#2676
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
mibac138
force-pushed
the
master
branch
2 times, most recently
from
391bd29 to
c10a9aa
Compare
|
ping @sgrif |
|
r? @jtgeibel to review/re-assign, as Siân is no longer a team member. |
mibac138
force-pushed
the
master
branch
3 times, most recently
from
67bd9e1 to
a6c6c70
Compare
Turbo87
added
C-enhancement ✨
|
☔ The latest upstream changes (presumably #3518) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
I've slightly adjusted the code to return an empty response with HTTP 204 (No Content), instead of the empty JSON object, and I've fixed the merge conflicts on the tests by rebasing them on master.
From my side this is good to go now.
@pietroalbini @jtgeibel any objections from your side?
|
LGTM! @bors r+ |
|
📌 Commit 7c42ae1 has been approved by |
|
☀️ Test successful - checks-actions |
Fixes #2653