Migrate routes to native classes #2291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @smarnach (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @Turbo87 |
Turbo87
reviewed
Mar 21, 2020
| }, | ||
| }, | ||
| }); | ||
| @action |
There was a problem hiding this comment.
I'm a little worried about this because I've had issues with the @action decorator on routes in the past 🤔
There was a problem hiding this comment.
Do you remember what the issue was? I tried checking the literature and this seemed the correct way to upgrade :/
There was a problem hiding this comment.
nope, unfortunately I don't remember the specifics, but I'd sleep better if I knew that we had better test coverage for these things :-/
|
☔ The latest upstream changes (presumably #2308) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.