Fix a deprecation warning during ember build
#2088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no usage of `sendAction` in the component, so I believe no futher changes are needed there.
DEPRECATION: Passing actions to components as strings (like `<Input @Enter="saveToken" />`) is deprecated.
Please use closure actions instead (`<Input @Enter={{action "saveToken"}} />`).
('cargo/templates/components/api-token-row.hbs' @ L4:C6) [deprecation id: ember-component.send-action]
See https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action for more details.
|
r? @smarnach (rust_highfive has picked a reviewer for you, use r? to override) |
Turbo87
approved these changes
Jan 5, 2020
|
@bors r=Turbo87 |
|
📌 Commit d4798bd has been approved by |
bors
added a commit
that referenced
this pull request
Jan 5, 2020
Fix a deprecation warning during `ember build` The lint references https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action. There is no usage of `sendAction` in the component, so I believe no further changes are needed there. r? Turbo87
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint references https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action. There is no usage of
sendActionin the component, so I believe no further changes are needed there.r? Turbo87