Simplify README rendering using a new highlight-syntax modifier
#2069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit 1db71ad has been approved by |
bors
added a commit
that referenced
this pull request
Dec 28, 2019
Simplify README rendering using a new `highlight-syntax` modifier This PR implements a new `highlight-syntax` modifier based on https://github.com/ember-modifier/ember-modifier and the existing `ember-prism` addon. That modifier is then used to apply the Prism.js syntax highlighting to all code blocks in the README, making the `CrateReadme` component obsolete. r? @locks
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new
highlight-syntaxmodifier based on https://github.com/ember-modifier/ember-modifier and the existingember-prismaddon. That modifier is then used to apply the Prism.js syntax highlighting to all code blocks in the README, making theCrateReadmecomponent obsolete.r? @locks