tests: Add basic "successful/failed login" test cases #2067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit f9007c1 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 28, 2019
tests: Add basic "successful/failed login" test cases This PR adds two basic application tests for the login button and the `login` route. Please note that this does not test the `github-login` and `github-authorize` routes yet, which we will do in a follow-up PR. r? @locks /cc @carols10cents
|
☀️ Test successful - checks-travis |
|
Catching up on what's been merged, this is awesome!!! Thank you so much!!! |
|
Yup, this is one of the tests that were most sorely missing from the frontend. Actually, the first time I tried to set up crates.io on my machine the login was broken, and it took me a while to figure out what's wrong since the error output goes to the ephemeral new window, and all tests pass. These tests would have caught the error with an easily accessible error message, and the broken change would have been fixed within minutes before it was even merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two basic application tests for the login button and the
loginroute. Please note that this does not test thegithub-loginandgithub-authorizeroutes yet, which we will do in a follow-up PR.r? @locks
/cc @carols10cents