Consolidate logging into a single println!()
#2064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In production I observed serveral log lines with only " SLOW REQUEST". Occasionally another thread will obtain the lock on stdout between our calls to `print!()`. This implementation consolidates the entire log line into a single `println!()` and avoids an allocation unless an error is being logged.
The call to `to_string()` results in an unnecessary allocation. `Error` only implements `ToString` through the `Display` trait. The same formatting logic is used, but calling `to_string()` causes an additional heap allocation.
Turbo87
approved these changes
Dec 30, 2019
|
@bors r+ |
|
📌 Commit e8dd729 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 31, 2019
Consolidate logging into a single `println!()` In production I observed serveral log lines with only " SLOW REQUEST". Occasionally another thread will obtain the lock on stdout between our calls to `print!()`. This implementation consolidates the entire log line into a single `println!()` and avoids an allocation unless an error is being logged. r? @smarnach
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production I observed serveral log lines with only " SLOW REQUEST".
Occasionally another thread will obtain the lock on stdout between our
calls to
print!().This implementation consolidates the entire log line into a single
println!()and avoids an allocation unless an error is being logged.r? @smarnach