Use absolute path for GIT_REPO_URL file:// URL #2051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
file:// URLs do not support relative paths. This change uses $PWD to make an absolute path based on where the user is running Crates on their local machine. This fixes issue rust-lang#2030
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks for the fix! I wasn't sure whether environment variables are expanded during processing of A @bors r+ |
|
📌 Commit 6105bea has been approved by |
bors
added a commit
that referenced
this pull request
Dec 23, 2019
Use absolute path for GIT_REPO_URL file:// URL file:// URLs do not support relative paths. This change uses $PWD to make an absolute path based on where the user is running Crates on their local machine. This fixes issue #2030
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file:// URLs do not support relative paths. This change uses $PWD to make an absolute path based on where the user is running Crates on their local machine.
This fixes issue #2030