Enable debug MALLOC_CONF options on CI #2031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully #2027 (comment) was just a fluke. If not, this should make things worse I guess, lol. The tests run fine for me locally. |
On top of the production configuration, this commit adds two options: * `abort:true` - most jemalloc warnings become fatal ([opt.abort]) * `junk:true` - both allocated and deallocated memory will be initialized to 0xa5. ([opt.junk]) Combined with the existing `abort_conf:true`, this should be equivalent to enabling the `debug` feature of `jemallocator`. We cannot enable this feature in `Cargo.toml` because that would affect performance in production. [opt.abort]: http://jemalloc.net/jemalloc.3.html#opt.abort [opt.junk]: http://jemalloc.net/jemalloc.3.html#opt.junk
jtgeibel
force-pushed
the
ci/malloc_conf
branch
from
9874f20 to
8cd03c7
Compare
|
LGTM! 🤷♀ @bors r+ |
|
📌 Commit 8cd03c7 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 23, 2019
Enable debug MALLOC_CONF options on CI On top of the production configuration, this commit adds two options: * `abort:true` - most jemalloc warnings become fatal ([opt.abort]) * `junk:true` - both allocated and deallocated memory will be initialized to 0xa5. ([opt.junk]) Combined with the existing `abort_conf:true`, this should be equivalent to enabling the `debug` feature of `jemallocator`. We cannot enable this feature in `Cargo.toml` because that would affect performance in production. [opt.abort]: http://jemalloc.net/jemalloc.3.html#opt.abort [opt.junk]: http://jemalloc.net/jemalloc.3.html#opt.junk r? @carols10cents
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of the production configuration, this commit adds two options:
abort:true- most jemalloc warnings become fatal (opt.abort)junk:true- both allocated and deallocated memory will beinitialized to 0xa5. (opt.junk)
Combined with the existing
abort_conf:true, this should be equivalentto enabling the
debugfeature ofjemallocator. We cannot enablethis feature in
Cargo.tomlbecause that would affect performance inproduction.
r? @carols10cents