Skip to content

dependency-lint: Disable generateTests option #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 17, 2019

We already run npm run lint:deps as part of CI, there is no need to also generate tests for this and slow down the build doing so.

We already run `npm run lint:deps` as part of CI, there is no need to also generate tests for this and slow down the build doing so.
@rust-highfive
Copy link

r? @carols10cents

(rust_highfive has picked a reviewer for you, use r? to override)

@locks
Copy link
Contributor

locks commented Dec 17, 2019

Sounds good!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 17, 2019

📌 Commit d5487b5 has been approved by locks

@bors
Copy link
Contributor

bors commented Dec 17, 2019

⌛ Testing commit d5487b5 with merge 54ff8b9...

bors added a commit that referenced this pull request Dec 17, 2019
dependency-lint: Disable `generateTests` option

We already run `npm run lint:deps` as part of CI, there is no need to also generate tests for this and slow down the build doing so.
@bors
Copy link
Contributor

bors commented Dec 17, 2019

☀️ Test successful - checks-travis
Approved by: locks
Pushing 54ff8b9 to master...

@bors bors merged commit d5487b5 into rust-lang:master Dec 17, 2019
@Turbo87 Turbo87 deleted the dep-lint branch January 3, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants