Query GitHub teams directly by name #1945
Conversation
Allows users to use the 101st-created team on their GitHub organization for staggeringly large organizations by querying the team directly.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| id: i32, // unique GH id (needed for membership queries) | ||
| name: Option<String>, // Pretty name | ||
| } | ||
|
|
||
| // FIXME: we just set per_page=100 and don't bother chasing pagination | ||
| // links. A hundred teams should be enough for any org, right? |
|
@bors r+ |
|
📌 Commit 4cc54a9 has been approved by |
Query GitHub teams directly by name I was having trouble adding the `github:awslabs:tough` team to [one of our new crates](https://crates.io/crates/tough) because the awslabs org has over 100 teams. This allows users to use the 101st-created team on their GitHub organization for staggeringly large organizations by querying the team directly. Test data was updated by hand per guidance in #crates-io, based on similar queries I made manually, but I would greatly appreciate if someone with access to actually make these API calls tested things work. :)
|
☀️ Test successful - checks-travis |
|
I've deployed this; please try adding the team again and let me know if it doesn't work :) Thank you for the fix!! |
Perfect! |
I was having trouble adding the
github:awslabs:toughteam to one of our new crates because the awslabs org has over 100 teams.This allows users to use the 101st-created team on their GitHub organization for staggeringly large organizations by querying the team directly.
Test data was updated by hand per guidance in #crates-io, based on similar queries I made manually, but I would greatly appreciate if someone with access to actually make these API calls tested things work. :)