Use CrateOwner::by_owner_kind everywhere to exclude deleted ownerships
#1940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @smarnach (rust_highfive has picked a reviewer for you, use r? to override) |
carols10cents
force-pushed
the
owned-crates-shouldnt-include-deleted
branch
from
3482988 to
9c32906
Compare
|
LGTM @bors r+ |
|
📌 Commit 9c32906 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 12, 2019
…ted, r=smarnach Use `CrateOwner::by_owner_kind` everywhere to exclude deleted ownerships I found some places I missed checking for where we should be using the new `CrateOwner::by_owner_kind` helper method added in 6d94155 that adds the filter for `deleted` being false. I've also added one test that currently passes and two tests that failed before this fix to hopefully cover everywhere that selects crate owners; the other places already have tests.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some places I missed checking for where we should be using the new
CrateOwner::by_owner_kindhelper method added in 6d94155 that adds the filter fordeletedbeing false.I've also added one test that currently passes and two tests that failed before this fix to hopefully cover everywhere that selects crate owners; the other places already have tests.