Skip to content

Move check mark SVG to static file #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

DSpeckhals
Copy link
Contributor

The content security policy of the production website was set up to not allow data URL's. Moving the logo to a static SVG policy fixes this.

Fixes #1938

The content security policy of the production website was set up to not
allow data URL's. Moving the logo to a static SVG policy fixes this.
@rust-highfive
Copy link

r? @jtgeibel

(rust_highfive has picked a reviewer for you, use r? to override)

@carols10cents
Copy link
Member

I tried this out locally and it was trying to load from /assets/assets/check-mark.svg, so it looks like the path needed to start with a slash. I went ahead and made that change, tested it out on staging to be sure, and this works! Thank you for the quick fix!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 5, 2019

📌 Commit f0c17e1 has been approved by carols10cents

@bors
Copy link
Contributor

bors commented Dec 5, 2019

⌛ Testing commit f0c17e1 with merge 3e5dd28...

bors added a commit that referenced this pull request Dec 5, 2019
Move check mark SVG to static file

The content security policy of the production website was set up to not allow data URL's. Moving the logo to a static SVG policy fixes this.

Fixes #1938
@bors
Copy link
Contributor

bors commented Dec 5, 2019

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing 3e5dd28 to master...

@bors bors merged commit f0c17e1 into rust-lang:master Dec 5, 2019
@DSpeckhals DSpeckhals deleted the check-mark-static-file branch December 5, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content security policy disallows data SVG in CSS
5 participants