conditionally add request metadata length to log output (no test) #1905
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
waiting on a full local build to manually test the addition. |
smokytheangel0
force-pushed
the
master
branch
from
ceea6f0 to
5db332e
Compare
|
I think I may have handled git wrong here, I reverted some other changes and added crates.io upstream so that I could stay level with it in the future, I don't see anything wrong with the latest commit though, so please let me know if I messed anything up. |
carols10cents
force-pushed
the
master
branch
from
c7e7c5b to
92c4dcb
Compare
|
Thank you so much!!! @bors r+ |
|
📌 Commit 92c4dcb has been approved by |
conditionally add request metadata length to log output (no test) This pull request implements the first step in determining a maximum metadata size for uploads as described in issue 1896 [https://github.com/rust-lang/crates.io/issues/1896](url). There was no test added for this change as log output is not automatically tested.
|
☀️ Test successful - checks-travis |
This pull request implements the first step in determining a maximum metadata size for uploads as described in issue 1896 #1896. There was no test added for this change as log output is not automatically tested.