Skip to content

Fix error response payload parsing #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Conversation

jtescher
Copy link
Contributor

Caught request error objects do not have a payload property, this should start properly showing error details instead of the generic fallback message.

Fixes #1547

@rust-highfive
Copy link

r? @jtgeibel

(rust_highfive has picked a reviewer for you, use r? to override)

@jtgeibel
Copy link
Member

Thanks @jtescher, this looks good to me! Thanks for the PR.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 23, 2019

📌 Commit b46123f has been approved by jtgeibel

bors added a commit that referenced this pull request Oct 23, 2019
Fix error response payload parsing

Caught request error objects do not have a payload property, this should start properly showing error details instead of the generic fallback message.

Fixes #1547
@bors
Copy link
Contributor

bors commented Oct 23, 2019

⌛ Testing commit b46123f with merge 68a77de...

@bors
Copy link
Contributor

bors commented Oct 23, 2019

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing 68a77de to master...

@bors bors merged commit b46123f into rust-lang:master Oct 23, 2019
@jtescher jtescher deleted the error-messages branch October 24, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ownership invitations to blocked groups don't error in UI
4 participants