Skip to content

Bump CI stack from xenial to bionic #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2020
Merged

Bump CI stack from xenial to bionic #1867

merged 2 commits into from
Sep 27, 2020

Conversation

jtgeibel
Copy link
Member

@jtgeibel jtgeibel commented Oct 14, 2019 •
edited
Loading

We'll want to synchronize this bump with a bump to the heroku-18 stack in production. See the tracking issue for details.

closes: #1868

@rust-highfive
Copy link

r? @sgrif

(rust_highfive has picked a reviewer for you, use r? to override)

@jtgeibel jtgeibel force-pushed the run-ci-on-bionic branch 13 times, most recently from 22c0aa2 to 110cca6 Compare October 20, 2019 18:22
@jtgeibel
Copy link
Member Author

I've noticed one regression introduced by this. It appears that the bionic VM images on Travis behave differently between rust and node_js configurations. The Frontend tests now pause for 5 minutes while starting the postgresql 11 service, before timing out. These tests don't need a PG server to run, but it is unfortunate that the test needlessly blocks for 5 minutes (although it is still the quickest job). I haven't looked into this in depth yet, but based on a few searches it looks like the bionic images aren't as mature (for all languages) as I had originally hoped.

@bors
Copy link
Contributor

bors commented Nov 21, 2019

☔ The latest upstream changes (presumably #1902) made this pull request unmergeable. Please resolve the merge conflicts.

@jtgeibel jtgeibel force-pushed the run-ci-on-bionic branch 3 times, most recently from 0833183 to aa6e955 Compare September 20, 2020 17:28
@jtgeibel
Move addons to specific jobs
3b46fa5 
The node_js containers hang for 5 minute when starting postgres 11,
which is not needed for those tests. The rust containers fail to
install chrome (because its deps are not installed by default there)
and it is not needed for those tests.

This also cleans up two validation warnings.
@jtgeibel jtgeibel mentioned this pull request Sep 20, 2020
Closed
3 tasks
@jtgeibel
Copy link
Member Author

Okay, I'm moving this out of draft status and assigning for review. We will want to wait until the staging and production environment are upgraded before merging.

r? @JohnTitor

@jtgeibel jtgeibel marked this pull request as ready for review September 20, 2020 17:57
@jtgeibel jtgeibel mentioned this pull request Sep 20, 2020
Closed
@jtgeibel
Copy link
Member Author

Production is now on heroku-18, merging so that CI matches.

@bors r+

@bors
Copy link
Contributor

bors commented Sep 27, 2020

📌 Commit 3b46fa5 has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Sep 27, 2020

⌛ Testing commit 3b46fa5 with merge b84bd8f...

@bors
Copy link
Contributor

bors commented Sep 27, 2020

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing b84bd8f to master...

@bors bors merged commit b84bd8f into rust-lang:master Sep 27, 2020
@jtgeibel jtgeibel deleted the run-ci-on-bionic branch November 12, 2020 01:06
jtgeibel added a commit to jtgeibel/crates.io that referenced this pull request Nov 12, 2020
@jtgeibel
CI: Upgrade to ubuntu-18.04
2fbc91f 
This was missed in rust-lang#1867 which only changed the frontend.
@jtgeibel jtgeibel mentioned this pull request Nov 12, 2020
Merged
bors added a commit that referenced this pull request Nov 12, 2020
@bors
Auto merge of #3022 - jtgeibel:gh-actions-bionic, r=Turbo87
ae7250a 
CI: Upgrade to ubuntu-18.04

This was missed in #1867 which only changed the frontend.

r? `@Turbo87`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JohnTitor JohnTitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue for upgrading to heroku-18 stack
5 participants
@jtgeibel @rust-highfive @bors @sgrif @JohnTitor