Skip to content

Fix GitHub relative SVGs not rendering properly #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

raftario
Copy link
Contributor

Fixes #1851 where SVGs from GitHub aren't rendered in READMEs if they use relative links.

First PR, so if I did something wrong point it out!

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@fundon
Copy link

fundon commented Nov 5, 2019

Need merge it.

@carols10cents carols10cents assigned carols10cents and unassigned sgrif Nov 7, 2019
Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm going to merge later this afternoon after a change I need to deploy by itself. Thank you so much!

@carols10cents
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 7, 2019

📌 Commit b4d1464 has been approved by carols10cents

@bors
Copy link
Contributor

bors commented Nov 7, 2019

⌛ Testing commit b4d1464 with merge 150ba49...

bors added a commit that referenced this pull request Nov 7, 2019
Fix GitHub relative SVGs not rendering properly

Fixes #1851 where SVGs from GitHub aren't rendered in READMEs if they use relative links.

First PR, so if I did something wrong point it out!
@bors
Copy link
Contributor

bors commented Nov 7, 2019

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing 150ba49 to master...

@bors bors merged commit b4d1464 into rust-lang:master Nov 7, 2019
@raftario raftario deleted the readme-svg branch November 8, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVGs from GitHub aren't rendered correctly in README
6 participants