Skip to content

Adjust branding to reflect what crates.io actually does #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1">

<title>Cargo: packages for Rust</title>
<title>crates.io: Rust Package Registry</title>

{{content-for 'head'}}

Expand Down
2 changes: 1 addition & 1 deletion app/templates/application.hbs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{{head-layout}}

{{title "Cargo: packages for Rust" separator=' - ' prepend=true}}
{{title "crates.io: Rust Package Registry" separator=' - ' prepend=true}}
{{google-jsapi}}

<nav id="header">
Expand Down
6 changes: 3 additions & 3 deletions config/manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

module.exports = function(/* environment, appConfig */) {
return {
name: 'Cargo: packages for Rust',
short_name: 'Cargo',
description: 'Cargo is the package manager and crate host for Rust.',
name: 'crates.io: Rust Package Registry',
short_name: 'crates.io',
description: 'crates.io is the default crate host for Rust.',
start_url: '/',
display: 'standalone',
background_color: '#3b6837',
Expand Down
8 changes: 4 additions & 4 deletions tests/acceptance/crate-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ module('Acceptance | crate page', function(hooks) {
await click('[data-test-just-updated] [data-test-crate-link="0"]');

assert.equal(currentURL(), '/crates/nanomsg');
assert.equal(document.title, 'nanomsg - Cargo: packages for Rust');
assert.equal(document.title, 'nanomsg - crates.io: Rust Package Registry');
});

test('visiting /crates/nanomsg', async function(assert) {
Expand All @@ -78,7 +78,7 @@ module('Acceptance | crate page', function(hooks) {

assert.equal(currentURL(), '/crates/nanomsg');
assert.equal(currentRouteName(), 'crate.index');
assert.equal(document.title, 'nanomsg - Cargo: packages for Rust');
assert.equal(document.title, 'nanomsg - crates.io: Rust Package Registry');

assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg');
assert.dom('[data-test-heading] [data-test-crate-version]').hasText('0.6.1');
Expand All @@ -93,7 +93,7 @@ module('Acceptance | crate page', function(hooks) {

assert.equal(currentURL(), '/crates/nanomsg/');
assert.equal(currentRouteName(), 'crate.index');
assert.equal(document.title, 'nanomsg - Cargo: packages for Rust');
assert.equal(document.title, 'nanomsg - crates.io: Rust Package Registry');

assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg');
assert.dom('[data-test-heading] [data-test-crate-version]').hasText('0.6.1');
Expand All @@ -108,7 +108,7 @@ module('Acceptance | crate page', function(hooks) {

assert.equal(currentURL(), '/crates/nanomsg/0.6.0');
assert.equal(currentRouteName(), 'crate.version');
assert.equal(document.title, 'nanomsg - Cargo: packages for Rust');
assert.equal(document.title, 'nanomsg - crates.io: Rust Package Registry');

assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg');
assert.dom('[data-test-heading] [data-test-crate-version]').hasText('0.6.0');
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/crates-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ module('Acceptance | crates page', function(hooks) {
await click('[data-test-all-crates-link]');

assert.equal(currentURL(), '/crates');
assert.equal(document.title, 'Crates - Cargo: packages for Rust');
assert.equal(document.title, 'Crates - crates.io: Rust Package Registry');
});

test('visiting the crates page directly', async function(assert) {
Expand All @@ -49,7 +49,7 @@ module('Acceptance | crates page', function(hooks) {
await click('[data-test-all-crates-link]');

assert.equal(currentURL(), '/crates');
assert.equal(document.title, 'Crates - Cargo: packages for Rust');
assert.equal(document.title, 'Crates - crates.io: Rust Package Registry');
});

test('listing crates', async function(assert) {
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/front-page-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module('Acceptance | front page', function(hooks) {
await visit('/');

assert.equal(currentURL(), '/');
assert.equal(document.title, 'Cargo: packages for Rust');
assert.equal(document.title, 'crates.io: Rust Package Registry');

assert.dom('[data-test-install-cargo-link]').exists();
assert.dom('[data-test-all-crates-link]').exists();
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/search-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ module('Acceptance | search', function(hooks) {
await triggerEvent('[data-test-search-form]', 'submit');

assert.equal(currentURL(), '/search?q=rust');
assert.equal(document.title, "Search Results for 'rust' - Cargo: packages for Rust");
assert.equal(document.title, "Search Results for 'rust' - crates.io: Rust Package Registry");

assert.dom('[data-test-heading]').hasText("Search Results for 'rust'");
assert.dom('[data-test-search-nav]').hasText('Displaying 1-8 of 8 total results');
Expand All @@ -53,7 +53,7 @@ module('Acceptance | search', function(hooks) {
await visit('/search?q=rust');

assert.equal(currentURL(), '/search?q=rust');
assert.equal(document.title, "Search Results for 'rust' - Cargo: packages for Rust");
assert.equal(document.title, "Search Results for 'rust' - crates.io: Rust Package Registry");

assert.dom('[data-test-search-input]').hasValue('rust');
assert.dom('[data-test-heading]').hasText("Search Results for 'rust'");
Expand Down