Skip to content

Ignore auto instead of staging.tmp on Travis CI #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Conversation

kzys
Copy link
Contributor

@kzys kzys commented Apr 17, 2019

Fixes #1603.

@carols10cents
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 25, 2019

📌 Commit b089f2e has been approved by carols10cents

@bors
Copy link
Contributor

bors commented Apr 25, 2019

⌛ Testing commit b089f2e with merge 721490a...

bors added a commit that referenced this pull request Apr 25, 2019
Ignore auto instead of staging.tmp on Travis CI

Fixes #1603.
@carols10cents
Copy link
Member

Thank you!!

@jtgeibel
Copy link
Member

Doesn't bors run its tests on auto? I'm not sure this will work.

@bors
Copy link
Contributor

bors commented Apr 25, 2019

💥 Test timed out

@carols10cents
Copy link
Member

Oops. I guess not. @kzys could you change this to just remove the ignoring of staging.tmp and the reference to bors-ng, but not ignore auto? Thanks!

@jtgeibel
Copy link
Member

@kzys thanks for looking into this! I agree with the changes Carol suggests.

It looks like Homu recommends running tests only: on the auto branch. While it is rarely used, we currently allow merging via GitHub GUI and allow pushes directly to master. Those could be locked down, but in both cases it looks like someone with rust-lang org permissions would need to do that. So unless we change that, we should continue running tests on all branches for now.

Thanks again!

@kzys
Copy link
Contributor Author

kzys commented Apr 26, 2019

just remove the ignoring of staging.tmp and the reference to bors-ng, but not ignore auto?

Doesn't it make the entire branches: block empty?

@jtgeibel
Copy link
Member

LGTM!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2019

📌 Commit ad5d236 has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Apr 26, 2019

⌛ Testing commit ad5d236 with merge 681d1ba...

bors added a commit that referenced this pull request Apr 26, 2019
Ignore auto instead of staging.tmp on Travis CI

Fixes #1603.
@bors
Copy link
Contributor

bors commented Apr 26, 2019

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing 681d1ba to master...

@bors bors merged commit ad5d236 into rust-lang:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update .travis.yml now that we are using Homu
4 participants