Skip to content

Rename "Game engines" to "Game Development" #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

kzys
Copy link
Contributor

@kzys kzys commented Apr 16, 2019

See #1598 for the discussion.

@kzys
Copy link
Contributor Author

kzys commented Apr 16, 2019

Ah, changing the slug means that we have to make some changes on the production database as well...

@kzys
Copy link
Contributor Author

kzys commented Apr 20, 2019

So, we cannot merge the change as is. Renaming "Game Engines" to "Game Development" makes sense though.

@jtgeibel
Copy link
Member

jtgeibel commented May 8, 2019

Would it be better to just add a new slug? I think it may be confusing if developers still have to add the "game-engine" slug to their Cargo.toml even though the category has been renamed.

@sgrif
Copy link
Contributor

sgrif commented May 13, 2019

I think it'd be even more confusing to have a separate "Game Development" category ("Game Engines" aren't for "Game Development"?). We definitely can't just change the slug though, even if we updated the existing data we'd unlist all existing crates when they published a new version.

We should probably have some form of migration strategy here rather than just assuming we'll always get categories exactly right the first time. We'll likely need to add some form of aliases field to categories and use that for lookup as well on publish. I agree with @jtgeibel that it'd be confusing to change the display name by itself.

sgrif
sgrif previously requested changes May 13, 2019
Copy link
Contributor

@sgrif sgrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

@kzys
Copy link
Contributor Author

kzys commented May 14, 2019

Sorry, I wasn't aware the impact of this change.

Game Engines are for Game Development, but the description ("Crates for creating games.") and the existing creates are more aligned with "Game Development". Game engines usually refer full-fledged frameworks such as Unity and/or Unreal Engine.

We already have a few categories that are the subset of the existing categories, such as Algorithms vs. Compression. I think having separate "Game Engine" is okay, while we may ask the Rust community to migrate their crates from Game Engine to Game Development though.

Having aliases doesn't need this community effort, but adds some complexity on the crates.io.

What do you think?

Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry we've let this sit so long without feedback!

I think adding a new "Game development" category with a description that it's for not-engines and adjusting the description for "Game engines" so that it's clear what belongs there vs. "Game development" would be a good path forward.

@kzys
Copy link
Contributor Author

kzys commented Nov 4, 2019

Thanks. Will update the TOML soon.

@carols10cents carols10cents self-assigned this Nov 15, 2019
While we already have "Game engines", "engines" are usually used for
full-fledged frameworks such as Unity.

Fixes rust-lang#1598
@carols10cents carols10cents dismissed sgrif’s stale review December 12, 2019 21:12

Concern has been addressed

@carols10cents
Copy link
Member

Noticed this PR was updated; looks great now! Thank you!!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 12, 2019

📌 Commit 701f2ae has been approved by carols10cents

@bors
Copy link
Contributor

bors commented Dec 12, 2019

⌛ Testing commit 701f2ae with merge bf95de8...

bors added a commit that referenced this pull request Dec 12, 2019
Rename "Game engines" to "Game Development"

See #1598 for the discussion.
@bors
Copy link
Contributor

bors commented Dec 12, 2019

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing bf95de8 to master...

@bors bors merged commit 701f2ae into rust-lang:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants