-
Notifications
You must be signed in to change notification settings - Fork 649
Rename "Game engines" to "Game Development" #1720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ah, changing the slug means that we have to make some changes on the production database as well... |
So, we cannot merge the change as is. Renaming "Game Engines" to "Game Development" makes sense though. |
Would it be better to just add a new slug? I think it may be confusing if developers still have to add the "game-engine" slug to their |
I think it'd be even more confusing to have a separate "Game Development" category ("Game Engines" aren't for "Game Development"?). We definitely can't just change the slug though, even if we updated the existing data we'd unlist all existing crates when they published a new version. We should probably have some form of migration strategy here rather than just assuming we'll always get categories exactly right the first time. We'll likely need to add some form of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
Sorry, I wasn't aware the impact of this change. Game Engines are for Game Development, but the description ("Crates for creating games.") and the existing creates are more aligned with "Game Development". Game engines usually refer full-fledged frameworks such as Unity and/or Unreal Engine. We already have a few categories that are the subset of the existing categories, such as Algorithms vs. Compression. I think having separate "Game Engine" is okay, while we may ask the Rust community to migrate their crates from Game Engine to Game Development though. Having aliases doesn't need this community effort, but adds some complexity on the crates.io. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry we've let this sit so long without feedback!
I think adding a new "Game development" category with a description that it's for not-engines and adjusting the description for "Game engines" so that it's clear what belongs there vs. "Game development" would be a good path forward.
Thanks. Will update the TOML soon. |
While we already have "Game engines", "engines" are usually used for full-fledged frameworks such as Unity. Fixes rust-lang#1598
b81183c
to
701f2ae
Compare
Noticed this PR was updated; looks great now! Thank you!! @bors r+ |
📌 Commit 701f2ae has been approved by |
Rename "Game engines" to "Game Development" See #1598 for the discussion.
☀️ Test successful - checks-travis |
See #1598 for the discussion.