Skip to content

Bump tar dependency to the latest #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Bump tar dependency to the latest #1651

merged 1 commit into from
Mar 8, 2019

Conversation

alex
Copy link
Member

@alex alex commented Mar 8, 2019

No description provided.

@alex
Copy link
Member Author

alex commented Mar 8, 2019

This ensures that crates.io isn't vulnerable to https://rustsec.org/advisories/RUSTSEC-2018-0002.html

I think it'd be a good idea to use cargo-audit in CI.

@jtgeibel
Copy link
Member

jtgeibel commented Mar 8, 2019

Just to clarify, we manually deny any crate uploads containing a symlink or hardlink, and should not be vulnerable to this on the sever backend. This also protects older clients using older versions of the crate from downloading a bad crate.

@alex
Copy link
Member Author

alex commented Mar 8, 2019

Sorry, I should have been clear -- I didn't think crates.io was actually vulnerable to this, but I'm a big believer in security-through-resillience :-) I assume no one is in favor of keeping the vulnerable dependency around :P

@sgrif
Copy link
Contributor

sgrif commented Mar 8, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 8, 2019

📌 Commit a43c137 has been approved by sgrif

@bors
Copy link
Contributor

bors commented Mar 8, 2019

⌛ Testing commit a43c137 with merge 3246bcb...

bors added a commit that referenced this pull request Mar 8, 2019
Bump tar dependency to the latest
@bors
Copy link
Contributor

bors commented Mar 8, 2019

☀️ Test successful - checks-travis
Approved by: sgrif
Pushing 3246bcb to master...

@bors bors merged commit a43c137 into rust-lang:master Mar 8, 2019
@alex alex deleted the bump-tar branch March 8, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants