Use the --locked-schema flag in Diesel 1.4
#1611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag tells Diesel CLI to error if a command would change `src/schema.rs`, rather than updating it. By running this in CI and production builds, we ensure that no PR will pass which changes schema but doesn't modify this file (which has happened in the past)
|
@bors r+ |
|
📌 Commit 1cdb355 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 1, 2019
Use the `--locked-schema` flag in Diesel 1.4 This flag tells Diesel CLI to error if a command would change `src/schema.rs`, rather than updating it. By running this in CI and production builds, we ensure that no PR will pass which changes schema but doesn't modify this file (which has happened in the past)
|
☀️ Test successful - checks-travis |
|
I'm seeing this error out on Heroku on staging, but running locally succeeds (as no changes to src/schema.rs are needed). |
|
I'm thinking the issue is that we run |
|
Let's go ahead and revert for now then |
|
I'm working on a PR to remove this from just from the Procfile, unless you think we should revert the whole PR. |
jtgeibel
added a commit
to jtgeibel/crates.io
that referenced
this pull request
Feb 7, 2019
This reverts a portion of rust-lang#1611. Heroku does not make a checkout of the source code available at runtime, so at the point in time we run migrations `src/schema.rs` will not exist, and will thus always fail this check. The `--locked-schema` check is still run on CI, so this still gives us confidence that our schema and `src/schema.rs` do not diverge.
|
No that's fine |
bors
added a commit
that referenced
this pull request
Feb 7, 2019
Remove `--locked-schema` when running migrations on Heroku This reverts a portion of #1611. Heroku does not make a checkout of the source code available at runtime, so at the point in time we run migrations `src/schema.rs` will not exist, and will thus always fail this check. The `--locked-schema` check is still run on CI, so this still gives us confidence that our schema and `src/schema.rs` do not diverge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag tells Diesel CLI to error if a command would change
src/schema.rs, rather than updating it. By running this in CI andproduction builds, we ensure that no PR will pass which changes schema
but doesn't modify this file (which has happened in the past)